Skip to content

Commit

Permalink
[.github] Remove stray code (open-telemetry#29688)
Browse files Browse the repository at this point in the history
**Description:** 

We now have pdata 1.0.0 🎉. After
open-telemetry/opentelemetry-collector/pull/8975, we decided not to have
RC releases, so there is no need to have the RC block.
  • Loading branch information
mx-psi authored and jayasai470 committed Dec 8, 2023
1 parent 2521a10 commit 244b4b4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 18 deletions.
20 changes: 6 additions & 14 deletions .github/workflows/scripts/check-collector-module-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,12 @@ for mod in ${beta_modules[@]}; do
check_collector_versions_correct "$mod" "$BETA_MOD_VERSION"
done

# Check RC modules
RC_MODULE="go.opentelemetry.io/collector/pdata"
RC_MOD_VERSION=$(get_collector_version "$RC_MODULE " "$MAIN_MOD_FILE")
check_collector_versions_correct "$RC_MODULE" "$RC_MOD_VERSION"
for mod in ${rc_modules[@]}; do
check_collector_versions_correct "$mod" "$RC_MOD_VERSION"
done

# Check stable modules, none currently exist, uncomment when pdata is 1.0.0
# STABLE_MODULE="go.opentelemetry.io/collector/pdata "
# STABLE_MOD_VERSION=$(get_collector_version "$STABLE_MODULE" "$MAIN_MOD_FILE")
# check_collector_versions_correct "$STABLE_MODULE" "$STABLE_MOD_VERSION"
# for mod in ${stable_modules[@]}; do
# check_collector_versions_correct "$mod" "$STABLE_MOD_VERSION"
# done
STABLE_MODULE="go.opentelemetry.io/collector/pdata"
STABLE_MOD_VERSION=$(get_collector_version "$STABLE_MODULE" "$MAIN_MOD_FILE")
check_collector_versions_correct "$STABLE_MODULE" "$STABLE_MOD_VERSION"
for mod in ${stable_modules[@]}; do
check_collector_versions_correct "$mod" "$STABLE_MOD_VERSION"
done

git diff --exit-code
5 changes: 1 addition & 4 deletions internal/buildscripts/modules
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ beta_modules=(
"go.opentelemetry.io/collector/semconv"
)

rc_modules=(
stable_modules=(
"go.opentelemetry.io/collector/featuregate"
"go.opentelemetry.io/collector/pdata"
)

# No stable modules currently exist, add pdata here once 1.0.0
stable_modules=()

0 comments on commit 244b4b4

Please sign in to comment.