Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try adding animations for RawCell changes #94

Closed
Tracked by #55
jayasuryat opened this issue May 3, 2022 · 1 comment
Closed
Tracked by #55

Try adding animations for RawCell changes #94

jayasuryat opened this issue May 3, 2022 · 1 comment

Comments

@jayasuryat
Copy link
Owner

No description provided.

@jayasuryat jayasuryat mentioned this issue May 3, 2022
13 tasks
@jayasuryat jayasuryat changed the title Try adding animations for <code class="notranslate">RawCell` changes Try adding animations for RawCell changes May 3, 2022
@jayasuryat
Copy link
Owner Author

After bringing in a different model i.e., DisplayCell as a replacement for RawCell to better tackle diffing and animations, the overall performance has gotten better.

But, it is still not perfect. The game is able to handle RawCell changes with animations decently good until Hard difficulty, after that the performance with regards to the cell change animation deteriorates significantly.

The weird part is, leaving the cell change animations aside, even the pan/zoom performance is also taking a hit, the game is not able to keep up with the device frame rate when you just zoom or pan around. This isn't the case when animations are disabled, even for the Extreme difficulty panning has no perceived frame drops. So, in some weird way, wrapping a composable in an AnimatedContent is hindering performance of graphicsLayer transformations.

So, keeping all of this in mind, for now will disable cell change animations. Maybe at least for the more difficult levels where the frame drops are more evident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant