Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade fs-capacitor@^7.0.1 #290

Closed

Conversation

carmi2214
Copy link

@carmi2214 carmi2214 commented Dec 19, 2021

Upgraded fs-capacitor dependency to 7.0.1, in order to receive the following changes:
https://github.com/mike-marcacci/fs-capacitor/releases/tag/v7.0.0

@carmi2214 carmi2214 marked this pull request as ready for review December 19, 2021 23:29
Copy link
Owner

@jaydenseric jaydenseric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in contributing to the project. Sorry for not reviewing this PR earlier; I was waiting for a few things to pan out before doing so and time dragged on. I left it open as there was a slim chance I would be able to jump in and make some edits to merge it in and get you in the contribution graph.

graphql-upload will be converted to pure ESM, at which time the fs-capacitor dependency will be updated. This is something that I'll do very carefully myself, and will do it a little differently than this PR. We will use .mjs files for example instead of using a package module type with .js files.

Major changes such as updating dependencies and supported Node.js versions, implementing type safety via TypeScript JSDoc comments, removing the package main index module, removing /public/ from module paths, and more needed to happen and be published while the package is still CJS before publishing a major new pure ESM version. I've made recent progress on all those things and hope to publish them soon.

Something else significant is that our package going pure ESM will cause dual package hazards for people consuming both CJS and ESM versions of graphql. graphql v17 is going to be pure ESM, so it would make it not just easier but necessary for use to move to pure ESM at that time. My intention is to wait for a stable pure ESM graphql v17 release before moving graphql-upload to pure ESM. Hopefully this happens soon, and they don't chicken out on the decision. If they do, and we face a prospect of years of waiting for a pure ESM graphql in v18 or later, then I might reconsider just publishing pure ESM here early.

Believe me, I'm really looking forward to pure ESM and have already migrated most of my packages to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants