Skip to content

Commit

Permalink
fix(snapshot): correction of the compare results
Browse files Browse the repository at this point in the history
  • Loading branch information
jayree committed May 23, 2024
1 parent 1db2dd9 commit 3d91d14
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 19 deletions.
12 changes: 8 additions & 4 deletions lib/commands/jayree/project/compare/snapshot.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/commands/jayree/project/compare/snapshot.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/commands/jayree/project/generate/snapshot.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/commands/jayree/project/generate/snapshot.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/utils/parse.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { JsonMap } from '@salesforce/ts-types';
export declare function getParsedSourceComponents(projectPath: string | undefined): Promise<{
export declare function getParsedSourceComponents(uniquePackageDirectories: string[] | undefined, projectPath: string | undefined): Promise<{
[key: string]: JsonMap;
}>;
16 changes: 10 additions & 6 deletions lib/utils/parse.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/utils/parse.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions src/commands/jayree/project/compare/snapshot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,13 @@ export default class CompareSourceSnapshot extends SfCommand<CompareResponse> {
);

const diff = detailedDiff(orig, results) as { added: object; deleted: object; updated: object };

const addedMetadata = Object.keys(diff.added);
const removedMetadata = Object.keys(diff.deleted);
const modifiedMetadata = Object.keys(diff.updated);
const addedMetadata = Object.keys(diff.added).filter((k) => !(k in orig));
const removedMetadata = Object.keys(diff.deleted).filter((k) => !(k in results));
const modifiedMetadata = [
...Object.keys(diff.updated),
...Object.keys(diff.added).filter((k) => k in orig),
...Object.keys(diff.deleted).filter((k) => k in results),
].filter((value, index, self) => self.indexOf(value) === index);

if (addedMetadata.length === 0 && removedMetadata.length === 0 && modifiedMetadata.length === 0) {
this.log('No changes have been detected.');
Expand Down

0 comments on commit 3d91d14

Please sign in to comment.