Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable the menu opening animiation #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jleepeak
Copy link

@jleepeak jleepeak commented Nov 9, 2016

Animations seem to often be really screwed up on Android with react-native currently, and I've experienced the same thing with react-native-menu. The menu will 'flicker' briefly when opened. This is a temporary workaround that just disabled the animations if you setup a MenuContext like this:

Animations seem to often be really screwed up on Android with react-native currently, and I've experienced the same thing with react-native-menu. The menu will 'flicker' briefly when opened. This is a temporary workaround that just disabled the animations if you setup a MenuContext like this:

<MenuContext animate={false} />
@scriptfans
Copy link

+1 for this.

@bryaneaton13
Copy link

I just opened a PR to fix the Android flash. I still like this to be able to disable the animation, but I just wanted to let you know.
I would like an option for different animation types. This could make the menu opening more like the native Android functionality where it opens from one of the corners and kind of slides in.

#33

@fabriziomoscon
Copy link

@jaysoo I would also like the possibilities to disable the opening popup animation.
Each app UI is different from each other and for some apps having a scale animation will not look consistent with the rest of the UI.
Having the possibility to disable animation by config will be super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants