Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @nginx/reference-lib #323

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

danielledeleo
Copy link
Contributor

@danielledeleo danielledeleo commented Jun 7, 2024

Hi there, I work for F5 on the NGINX Community and Alliances team. As part of a recent hackathon we started publishing an npm package generated from nginx.org's XML sources.

See also: nginx/nginx-directive-reference, which was recently open sourced.

There are a few broken things in the website folder preventing previews (including on main), how would you like to resolve this?

Switch to using official NGINX libraries for reference material.
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nginx-editor-mrj8 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 4:08pm

@danielledeleo danielledeleo marked this pull request as ready for review June 7, 2024 18:04
@jaywcjlove
Copy link
Owner

I’m not sure what happened. When I installed dependencies with npm install, the preview example failed. But when I used yarn install to install dependencies, the preview example succeeded.

@danielledeleo yarn @ v1.22.21

@jaywcjlove jaywcjlove merged commit d5910a0 into jaywcjlove:main Jun 8, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 8, 2024
Switch to using official NGINX libraries for reference material. d5910a0
jaywcjlove added a commit that referenced this pull request Jun 8, 2024
@jaywcjlove
Copy link
Owner

@danielledeleo I couldn't resolve the issue with npm installation, which caused the preview to fail. I eventually solved the problem by using yarn@v1 for the installation. If you have resolved this issue, please share your solution. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants