Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in support for Python 3.13 #2014

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Adding in support for Python 3.13 #2014

merged 5 commits into from
Oct 13, 2024

Conversation

abeed-avayu
Copy link
Contributor

Description

This adds support for Python 3.13. I think I've got all the references, but there's probably somewhere else that I've overlooked.

Shout-out to London Django Meetup for the Hacktoberfest Hackathon inspiration. CC @adamchainz et al.

Testing notes

I ran this under docker (python:3.13-slim) locally and make test and make coverage passed all the tests. Would have also tried with a virtualenv but pyenv didn't have 3.13 (non-RC) at the time of testing.

Checklist:

  • [ x ] I have added the relevant tests for this change.
  • [ x ] I have added an item to the Pending section of docs/changes.rst.

Shout-out to London Django Meetup for the Hacktoberfest Hackathon
inspiration.
docs/changes.rst Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@matthiask
Copy link
Member

Thanks! The failures are probably due to psycopg2 not having 3.13-compatible wheels yet. (psycopg/psycopg2#1729)

I added some comments.

@abeed-avayu
Copy link
Contributor Author

I've probably overstepped the mark by removing 3.8 as it's end of life, but as the next version release looks to be a major one I thought it would be compatible with that. Let me know if that's a problem and I'll reinstate it.

@matthiask
Copy link
Member

matthiask commented Oct 10, 2024

I've probably overstepped the mark by removing 3.8 as it's end of life, but as the next version release looks to be a major one I thought it would be compatible with that. Let me know if that's a problem and I'll reinstate it.

On a pedantic day I'd like this to happen with a separate pull request. Today I'm feeling generous :) I think supporting 5 minor Python versions at the same time is enough and I'm therefore fine with it. CI isn't free energy wise after all.

docs/changes.rst Outdated Show resolved Hide resolved
tox.ini Outdated
@@ -49,28 +50,28 @@ pip_pre = True
commands = python -b -W always -m coverage run -m django test -v2 {posargs:tests}


[testenv:py{38,39,310,311,312}-dj{42,50,51,main}-{postgresql,psycopg3}]
[testenv:py{38,39,310,311,312,313}-dj{42,50,51,main}-{postgresql,psycopg3}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove 38 here and below as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So still struggling a bit to get the matrix running correctly. I think we only want py313 with dj51 and main, and then postgres and postgis DB backends but using psycopg as the adapter library.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@matthiask matthiask merged commit 22c92e4 into jazzband:main Oct 13, 2024
25 checks passed
@matthiask
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants