Move mockredis to test requirements #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary to be installed typically.
|
It might make sense to remove the |
2 similar comments
kencochrane
reviewed
Feb 19, 2018
| global MOCKED_REDIS | ||
| if MOCKED_REDIS is None: | ||
| import mockredis | ||
| MOCKED_REDIS = mockredis.mock_strict_redis_client() |
There was a problem hiding this comment.
We can probably make this even more simple.
if config.MOCK_REDIS:
import mockredis
return mockredis.mock_strict_redis_client()
Then we can remove the MOCKED_REDIS variable all together what do you think?
There was a problem hiding this comment.
Makes sense.
Please feel free to pick up this PR and/or do it from scratch - I've decided to not use django-defender, so will not update it myself.
kencochrane
added a commit
that referenced
this pull request
Feb 20, 2018
Signed-off-by: Ken Cochrane <KenCochrane@gmail.com>
|
closing, and replacing with #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to be installed typically.