Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace datetime.now with timezone.now #232

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

ericls
Copy link
Contributor

@ericls ericls commented Jul 12, 2023

Use timezone.now instead of datetime.now when constructing datetime objects. timezone.now ensures the timezone-awareness to be consistent with settings.USE_TZ

Use `timezone.now` instead of `datetime.now` when constructing datetime objects. `timezone.now` ensures the timezone-awareness to be consistent with `settings.USE_TZ`
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #232 (c755e91) into master (cc6145b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   92.92%   92.93%   +0.01%     
==========================================
  Files          13       13              
  Lines         438      439       +1     
==========================================
+ Hits          407      408       +1     
  Misses         31       31              
Impacted Files Coverage Δ
defender/data.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@kencochrane kencochrane merged commit 8d4c684 into jazzband:master Jul 13, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants