Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-opened PR (#696): Add aioapns version of APNS #739

Merged
merged 31 commits into from
Oct 6, 2024
Merged

Conversation

50-Course
Copy link
Member

@50-Course 50-Course commented Oct 3, 2024

This pull request reopens the original PR #696, which was inadvertently closed. It includes the necessary changes for adding the aioapns version of APNS.

I sincerely apologize for the confusion caused by my earlier actions. The changes have been pushed with proper attribution to the original author, @pomali .

Thank you for your understanding.

pre-commit-ci bot and others added 30 commits October 3, 2024 16:07
updates:
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Update tox.ini

* Update release.yml
* Update test.yml

Fixes failing python 3.6 tests

* Update test.yml
* [pre-commit.ci] pre-commit autoupdate (#669)
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/asottile/pyupgrade: v2.37.3 → v3.10.1](asottile/pyupgrade@v2.37.3...v3.10.1)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: jscarlett <jamaal.scarlett@gmail.com>
• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message
Co-authored-by: Ian Later <ilater@outlook.com>
* Add WebPush support for Safari

* Update webpush.py based on review

Declare results variable at the start of the block

* Fix typo in warning

Co-authored-by: Cuyler Stuwe <salembeats@gmail.com>

* Update README.rst

Co-authored-by: James Bligh <618250+blighj@users.noreply.github.com>

* Fix mailto: space

* Expanded documentation for Web Push (#558)

• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Attempt to fix tests

* Update README.rst

---------

Co-authored-by: James Bligh <james.bligh@silvercloudhealth.com>
Co-authored-by: Cuyler Stuwe <salembeats@gmail.com>
Co-authored-by: Éloi Rivard <eloi.rivard@nubla.fr>
Co-authored-by: Neil Littlejohns <n.littlejohns@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Add long_description settings to setup.py to address `twine check` errors
Since version python 3.10+ is not supported by `apns2` (because of dependency on `hyper`) we add `aioapns` version of sending APNs notifications.

We add installation extra `[APNS_ASYNC]` that installs aioapns and use new version of service if `aioapns` is installed. Tests are also conditional on installed modules/version of python.
* Add FCM v1 API

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add Unit Tests for GCMDeviceAdmin and fix FCM v1 tests

* fixes admin test for python 3.6

---------

Co-authored-by: Tim Jahn <tim@smartfactory.ch>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Jahn <tim@smartfactory.ch>
(fix missing space)
* Remove python 3.6 support.

* Remove unsupported code
@50-Course 50-Course changed the title Re-opened PR: Add aioapns version of APNS (Original Author - @pomali) Re-opened PR (#696): Add aioapns version of APNS (Original Author - @pomali) Oct 3, 2024
@50-Course 50-Course changed the title Re-opened PR (#696): Add aioapns version of APNS (Original Author - @pomali) Re-opened PR (#696): Add aioapns version of APNS Oct 3, 2024
@50-Course 50-Course merged commit caf9917 into master Oct 6, 2024
11 checks passed
@vitorguima
Copy link

@50-Course are you guys releasing the new version on PyPI?

@50-Course
Copy link
Member Author

50-Course commented Oct 19, 2024

Hi @vitorguima, jamaal is a better point of contact in that regard.
cc: @jamaalscarlett @pomali

@azmeuk azmeuk deleted the pomali/master branch October 19, 2024 11:38
@silviogutierrez
Copy link

@jamaalscarlett : could we get a version released on PyPI? It seems like everything is in place, just need it released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants