Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redis-py 4.0 #569

Closed
terencehonles opened this issue Nov 8, 2021 · 9 comments · Fixed by #581
Closed

Support redis-py 4.0 #569

terencehonles opened this issue Nov 8, 2021 · 9 comments · Fixed by #581

Comments

@terencehonles
Copy link
Contributor

Problem Statement

The Redis Python client is now in RC1 but introduces some breaking changes (specifically seen with the Sentinel configuration). This library should be updated to support the new changes ideally in a backwards compatiable manner.

@WisdomPill
Copy link
Member

there is already an issue for this, it is #542

@terencehonles
Copy link
Contributor Author

Well I think they're related, but is this the only thing that's broken in redis 4?

@hartwork
Copy link
Contributor

CC #575 #576

@aleehedl
Copy link

Is there any estimate when this will be available in a release?

@WisdomPill
Copy link
Member

I can release in the next days, max Monday.

Can I ask why you are looking for redis-py 4 as a dependency?

@WisdomPill
Copy link
Member

I would wait for #580 to be merged and then release

@WisdomPill WisdomPill reopened this Dec 17, 2021
@aleehedl
Copy link

Can I ask why you are looking for redis-py 4 as a dependency?

Yeah, because redis-py 4 was already installed into a production system and I'm not sure how a downgrade would pan out.

@WisdomPill
Copy link
Member

WisdomPill commented Dec 21, 2021

I can say that the only known issue is with sentinel commands that are different in 4.0.1 and 4.0.2,
the rest of the versions are supported,
I am waiting for @terencehonles to review #580 to support django 4 and drop support for django 2.2.

After that we can for sure release

@WisdomPill
Copy link
Member

Will release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants