-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored redis 4 and master in CI #575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
========================================
+ Coverage 57.7% 57.8% +0.1%
========================================
Files 39 39
Lines 2497 2497
Branches 63 73 +10
========================================
+ Hits 1440 1441 +1
+ Misses 1049 1041 -8
- Partials 8 15 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@hartwork do you think we could work around the issue with |
@WisdomPill technically yes, but please note #576 (comment) for the bigger picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WisdomPill Installation of package packaging
seems still missing.
PS: My vote for merging this without squashing after that addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WisdomPill the way how packaging
is added right now does not guarantee that it's installed prior to redis-py, which is causing the breakage. If that's not easily fixable, my vote for re-opening #576 and merge that fix in isolation, first.
agreed |
@WisdomPill thank you! |
8d50940
to
cd43aaa
Compare
No description provided.