Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored redis 4 and master in CI #575

Merged
merged 5 commits into from
Dec 17, 2021

Conversation

WisdomPill
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #575 (cd43aaa) into master (df9a325) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #575     +/-   ##
========================================
+ Coverage    57.7%   57.8%   +0.1%     
========================================
  Files          39      39             
  Lines        2497    2497             
  Branches       63      73     +10     
========================================
+ Hits         1440    1441      +1     
+ Misses       1049    1041      -8     
- Partials        8      15      +7     
Flag Coverage Δ
mypy 33.9% <ø> (+0.1%) ⬆️
tests 83.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
django_redis/cache.py 97.0% <0.0%> (ø)
tests/test_backend.py 14.7% <0.0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9a325...cd43aaa. Read the comment docs.

@WisdomPill WisdomPill marked this pull request as draft December 3, 2021 10:40
@WisdomPill
Copy link
Member Author

@hartwork do you think we could work around the issue with packaging by installing it when using redis-master?

@WisdomPill WisdomPill marked this pull request as ready for review December 13, 2021 10:59
@hartwork
Copy link
Contributor

@hartwork do you think we could work around the issue with packaging by installing it when using redis-master?

@WisdomPill technically yes, but please note #576 (comment) for the bigger picture.

Copy link
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WisdomPill Installation of package packaging seems still missing.
PS: My vote for merging this without squashing after that addition.

@hartwork hartwork mentioned this pull request Dec 13, 2021
Copy link
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WisdomPill the way how packaging is added right now does not guarantee that it's installed prior to redis-py, which is causing the breakage. If that's not easily fixable, my vote for re-opening #576 and merge that fix in isolation, first.

@WisdomPill
Copy link
Member Author

agreed

@hartwork
Copy link
Contributor

@WisdomPill thank you!

@WisdomPill WisdomPill merged commit 218e47c into jazzband:master Dec 17, 2021
@WisdomPill WisdomPill deleted the restore_redis_4 branch December 17, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants