Fix #638 Lazy access to Django settings. #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
========================================
+ Coverage 57.5% 60.0% +2.6%
========================================
Files 39 39
Lines 2528 2534 +6
Branches 74 69 -5
========================================
+ Hits 1452 1520 +68
+ Misses 1059 1001 -58
+ Partials 17 13 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Broken tests are related to another issue #645. |
|
HerdClient has no tests, I'm not happy about it, I'll try to write some basic tests at least. |
I don't know it changed.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I discovered even herd test settings existed, but were not running in tox, probably because tests didn't passed. It is working now. PR ready for review. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I agreed and did all requested changes, ready for a new review. |
WisdomPill
reviewed
Jun 12, 2023
| herd.CACHE_HERD_TIMEOUT = 2 | ||
|
|
||
| @pytest.fixture | ||
| def patch_itersize_setting() -> Iterable[None]: |
There was a problem hiding this comment.
very weird one but I trust you :)
WisdomPill
approved these changes
Jun 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.