-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare next release #342
Prepare next release #342
Conversation
fix django.db.migrations.exceptions.IrreversibleError: Operation <RunPython <function cleanup_tokens at 0x0000027CCB764820>> in knox.0006_auto_20160818_0932 is not reversible error when python manage,py migrate knox zero on django 4.0.4
fix migrate zero
Changes made were done to make the README.md easy to read.
* Allowed usage of custom AuthToken based on knox.AbstractAuthToken * moved get_token_model() to models, updated the docs Co-authored-by: Khalidm98 <khalid.refaat@gmail.com>
Update link to documentation
Update references to point to Jazzband
…etup test: Set up pre-commit hooks and fix quality nits
updates: - [github.com/PyCQA/isort: 5.11.5 → 5.12.0](PyCQA/isort@5.11.5...5.12.0)
[pre-commit.ci] pre-commit autoupdate
Avoid importing `django.test` in main code
Remove flake8 and isort from tox config
@johnraz Oh, that's a neat tool! I need to catch up the changelog with the merges though, there's quite a few things that were merged but are missing from there (all minor things or fixes though). |
Any updates on this? |
The fact that the MR is not progressing should give you a hint… We are still trying to gain shared access to the pypi repository and need to find some time to address the points above. |
update AuthTokenManager to support custom values
@johnraz Hi! Seems like we didn't get updates for 2 years now. We would really like to have more consistent updates as its a critical component. Is there anything that we can support here? |
@johnraz Jazzband has been invited to the pypi repo, is there anything else needed from me to get that handed over so this can progress without me? |
@max-wittig the only supportive thing to do at this stage is to be patient. @James1345 that’s awesome, I’m not sure if full access to the github repo was already given or not to jazzband but if that’s the case than nothing else should be needed! Thanks a lot for taking the time. |
@James1345 Thanks for the Pypi access! @johnraz I now have maintainer access on Pypi and can deploy new versions. |
Awesome I'll try to free up some time in the coming days - if you don't see me move feel free to take action too 😉 |
@giovannicimolin please see #355 it adds the changelog and should fix the conflict... |
add changelog for release
@johnraz Nice! I reviewed and merged the PR. I can do that when figuring out how to release a new version this week though! |
Thanks @giovannicimolin , I moved this MR from draft to ready ;) |
I've increased the version to major, as this kind of a big change asks for one. Fixes #357
docs(changelog): bump to 5.0.0, add token warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good, let's get this release going.
pip version 5? |
Thanks for the release! I love it that you put the warning right on top where people can see them! |
Some things that need to be done before develop is ready:
Keep this PR in draft until the above are done
@James1345 @giovannicimolin