Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading security alert from Readme #455

Closed
danielMicallef opened this issue Dec 17, 2020 · 2 comments · Fixed by #491
Closed

Remove misleading security alert from Readme #455

danielMicallef opened this issue Dec 17, 2020 · 2 comments · Fixed by #491

Comments

@danielMicallef
Copy link

Since issue 305 has been resolved the related security note can be removed from the readme:

SECURITY NOTE: Because Silk stores all HTTP requests into the database in plain text, it will store the request's sensitive information into the database in plain text (e.g. users' passwords!). This is a massive security concern. An issue has been created for this here.
@danjac
Copy link

danjac commented Feb 7, 2021

What's the status of this? Right now I'm only recommending silk for local usage because of this security alert.

@sergeyshevch
Copy link

Currently this alert in readme look outdated.

martin-thoma added a commit to martin-thoma/django-silk that referenced this issue Aug 24, 2021
@martin-thoma
DOC: Remove outdated security notice
25260dc 
Closes jazzband#455
@martin-thoma martin-thoma mentioned this issue Aug 24, 2021
Merged
sarathak pushed a commit that referenced this issue Aug 25, 2021
@martin-thoma
DOC: Remove outdated security notice (#491)
21a4058 
Closes #455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: Remove outdated security notice martin-thoma/django-silk
3 participants
@danjac @danielMicallef @sergeyshevch