Fix Django 2 deprecations #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertyw
force-pushed
the
django2-deprecations
branch
3 times, most recently
from
bc19b74 to
b90a68e
Compare
|
@albertyw I appreciate the work future proofing silk for Django 2. TravisCI is highlighting an error. Is it possible for you to look into that so I can merge this in? |
albertyw
force-pushed
the
django2-deprecations
branch
from
b90a68e to
268e256
Compare
albertyw
force-pushed
the
django2-deprecations
branch
from
268e256 to
040cea2
Compare
albertyw
force-pushed
the
django2-deprecations
branch
from
040cea2 to
f741446
Compare
Closed
|
@albertyw Thanks for addressing Django 2 deprecations! |
|
Next time, can we not squash commits? With pypi behind with releases, some people (at least me) are pinning to github hashes and if you squash commits, it means those exact commits don't get merged into master. |
|
@albertyw Yes I can do that. |
danielbradburn
pushed a commit
to crunchr/silk
that referenced
this pull request
Dec 8, 2017
* Make sure all OneToOneFields explicitly declare on_delete * Switch to django.urls for imports * Update test project for django 2 * Default to newer MIDDLEWARE setting * Declare required app_name variable for inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some deprecations to make silk compatible with django 2.0