Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py with adding a return of function bulk_update_with_history #1206

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

zhaojiejoe
Copy link
Contributor

@zhaojiejoe zhaojiejoe commented Jul 10, 2023

Django version above 4.0 returns the rows_updated for function bulk_update.

Description

Related Issue

Motivation and Context

keep the same feature with the Django version above 4.0

How Has This Been Tested?

with the testcase

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1206 (1ac8b61) into master (e375098) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   97.29%   97.30%           
=======================================
  Files          23       23           
  Lines        1259     1260    +1     
  Branches      204      204           
=======================================
+ Hits         1225     1226    +1     
  Misses         16       16           
  Partials       18       18           
Impacted Files Coverage Δ
simple_history/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 😄

Some minor changes that would be nice:

simple_history/tests/tests/test_utils.py Outdated Show resolved Hide resolved
simple_history/tests/tests/test_utils.py Outdated Show resolved Hide resolved
simple_history/utils.py Outdated Show resolved Hide resolved
simple_history/tests/tests/test_utils.py Outdated Show resolved Hide resolved
zhaojiejoe and others added 2 commits July 11, 2023 09:17
Co-authored-by: Anders <6058745+ddabble@users.noreply.github.com>
fix suggestion
@zhaojiejoe zhaojiejoe requested a review from ddabble July 11, 2023 01:30
@zhaojiejoe
Copy link
Contributor Author

Great! 😄

Some minor changes that would be nice:

Thanks.
Your suggestion is pretty good.
I have merged them.

ddabble
ddabble previously approved these changes Jul 11, 2023
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@ddabble ddabble merged commit afd02c3 into jazzband:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants