add django stubs for HistoricForeignKey #1264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 96.94% 96.95%
=======================================
Files 23 23
Lines 1277 1280 +3
Branches 210 210
=======================================
+ Hits 1238 1241 +3
Misses 21 21
Partials 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ddabble
requested changes
Sep 28, 2023
There was a problem hiding this comment.
A couple things:
ForeignKey.__class_getitem__()was not added before Django 4.1, and since we support Django 3.2 until its EOL, we either have to wait until then to merge this PR, or we have to find a workaround.- Would you mind explaining what the purpose is of adding these
TypeVars when they're not used anywhere in the class body ofHistoricForeignKey? 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add django stubs for HistoricForeignKey