-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 3.5.0 release #1290
Conversation
@ddabble I merged a few dependency updates since they were pretty minimal. Hopefully that was alright by you. I updated the project for 5.0, dropped 4.1 in #1289. There's a bug fix from August that would be really helpful to my project so I wanted to help things along to make it easier for the next release. There looks to be a couple of other nice features since 3.4.0 as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 23 23
Lines 1278 1278
Branches 211 211
=======================================
Hits 1238 1238
Misses 21 21
Partials 19 19 ☔ View full report in Codecov by Sentry. |
You're more than welcome to do so! Any help maintaining is greatly appreciated 😄
Nice, I'll take a look (and also check if there are more changes that should be done while upgrading to 5.0) once I have time, but I'm not sure I will before sometime after new year.. Btw, is it okay if I request reviews from you for some future PRs I have planned for this repo? 🙂 |
Yeah, feel free to request reviews from me in the future. I can't promise they'll be timely though 😁 |
Great! 😊
No worries, and I guess I can also relate to that 😅 |
1121f95
to
512067e
Compare
I rebased on |
Not a big deal. Next time if I want to do that, I'll create the branches on the repo. |
The 3.4.0 version was already set when the entry was added; see jazzband@78bcd0e#diff-ff3c479edefad986d2fe6fe7ead575a46b086e3bbcf0ccc86d85efc4a4c63c79R8
512067e
to
bd15095
Compare
@treyhunner @rossmechanic Could one of you publish v3.5.0 to PyPI? 🙂 |
Done! |
Description
This is based off on #1289. I don't know how to chain PRs across repos in GitHub, so this may need to be cleaned up a bit. Or closed outright and redone.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst