-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude fields #274
Exclude fields #274
Conversation
…de that use this method.
…nd 1.6, then I access the attribute fields in _meta
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 97.54% 97.58% +0.04%
==========================================
Files 13 13
Lines 570 580 +10
Branches 69 72 +3
==========================================
+ Hits 556 566 +10
Misses 7 7
Partials 7 7
Continue to review full report at Codecov.
|
@gyermolenko @macro1 Hi, I send this PR to replaces the PR #238. |
Looks good. It would be great to have this documented as well. Undocumented features can be frustrating both for contributors as well as users of the library. If you don't have time to add the documentation, we'll try to get it added when this is merged in the future. |
@macro1 Very good! I will now write the docs for this. |
3ffe151
to
3179eaf
Compare
@macro1 I already add the documentation about this. |
When is this released? We are really looking forward to it. Cheers for the good work! |
@joaojunior would you mind resolving the conflicts? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a useful feature! I requested a couple small grammatical changes to the documentation.
👍 from me once those changes are made! 😄
docs/advanced.rst
Outdated
Choosing fields to not be stored | ||
-------------------------------- | ||
|
||
It is possible to use the parameter ``excluded_fields`` to choice which fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
choice
-> choose
here
docs/advanced.rst
Outdated
question = models.CharField(max_length=200) | ||
pub_date = models.DateTimeField('date published') | ||
|
||
And you don't want to stored the changes for the field ``pub_date``, it is necessary to update the model to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to stored the changes
-> to store the changes
Create option to pass fields to not copy in history.
This new PR replaces the PR: #238