Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add history change reason to allow reasoning for the changes[2] #275

Merged
merged 8 commits into from
Jun 2, 2017

Conversation

joaojunior
Copy link
Contributor

This pull request replace the PR #152.
I send a message to @hmit, author of the PR #152 to ask about the modifications requested by @macro1. Then, I create this new PR enjoying the code from @hmit and make the changes requested by @macro1.

I added a function that you can call explicitly and pass the change reason. This function will be call, after a save or delete operations in the original model.

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #275 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   97.48%   97.54%   +0.05%     
==========================================
  Files          12       13       +1     
  Lines         557      570      +13     
  Branches       66       69       +3     
==========================================
+ Hits          543      556      +13     
  Misses          7        7              
  Partials        7        7
Impacted Files Coverage Δ
...ests/migration_test_app/migrations/0001_initial.py 100% <ø> (ø) ⬆️
simple_history/registry_tests/tests.py 100% <100%> (ø) ⬆️
simple_history/models.py 96.68% <100%> (ø) ⬆️
simple_history/utils.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76e446...6d282a7. Read the comment docs.

@leportella leportella merged commit c7fdfec into jazzband:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants