Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_queryset rather than model.objects #303

Merged
merged 1 commit into from
Jul 15, 2017
Merged

Conversation

WnP
Copy link
Contributor

@WnP WnP commented Jul 15, 2017

This able user to overwrite get_queryset safely.

For example I've got a meta model for soft delete, with a boolean is_void, which is by default filtered to False by meta model manager get_queryset method, note that this manager defined also a method all_include_void, so in the model admin I can use this latest method in model admin get_queryset, but without this fix it just doesn't work as expected.

let me know your thoughts.

@codecov-io
Copy link

codecov-io commented Jul 15, 2017

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          15       15           
  Lines         590      590           
  Branches       72       72           
=======================================
  Hits          576      576           
  Misses          7        7           
  Partials        7        7
Impacted Files Coverage Δ
simple_history/admin.py 98.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac00e0...2f07076. Read the comment docs.

@macro1
Copy link
Collaborator

macro1 commented Jul 15, 2017

@WnP List yourself in AUTHORS.rst, add your change to CHANGES.rst, and we'll get this merged!

@WnP
Copy link
Contributor Author

WnP commented Jul 15, 2017

@macro1 done, thanks for your quick answer and all your works on this project.

@macro1
Copy link
Collaborator

macro1 commented Jul 15, 2017

@WnP I've definitely been slacking lately. But thanks for that :)

@macro1 macro1 merged commit 15271ca into jazzband:master Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants