Don't populate excluded fields in populate history #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests the management command on an historical record which has excluded fields - tests the excluded fields are retrieved from the current model instance
Previously, it was pre-loading directly related objects.
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 97.14% 97.16% +0.02%
==========================================
Files 14 14
Lines 630 635 +5
Branches 87 89 +2
==========================================
+ Hits 612 617 +5
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
rossmechanic
deleted the
dont-populate-excluded-fields-in-populate-history
branch
blawson
reviewed
Jun 15, 2018
| with self.assertRaises(AttributeError): | ||
| historical.place | ||
|
|
||
| def test_nb_queries(self): |
There was a problem hiding this comment.
Why do you want to test the number of DB queries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebases #381 in order to get it merged for 2.1.1 release. Fixes error when trying to bulk_create history with excluded fields that occurs when running
populate_historymanagement command. Closes #402. Thanks @uadnan for this fix.Related Issue
#402
Types of changes
Checklist: