Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Django 4 testing and remove unsupported Python and Django versions #198

Merged
merged 6 commits into from
May 10, 2022
Merged

Add Django 4 testing and remove unsupported Python and Django versions #198

merged 6 commits into from
May 10, 2022

Conversation

vchrisb
Copy link
Contributor

@vchrisb vchrisb commented May 9, 2022 •
edited
Loading

  • removed unsupported Django Versions 2.2, 3.0, 3.1 and Python Version 3.6
  • added Django 4.0 and Python 3.10
  • Updated Mysql and Postgresql Versions
  • Updated Github Actions
  • fixed pre-commit.ci by adding basic pre-commit-config

clintonb
clintonb requested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@clintonb clintonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the test config, and this should be all set.

.github/workflows/test.yml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
clintonb
clintonb previously approved these changes May 10, 2022
View reviewed changes
@vchrisb
Copy link
Contributor Author

vchrisb commented May 10, 2022

please don't merge yet. There is still a mistake...

@clintonb clintonb dismissed their stale review May 10, 2022 05:41

Awaiting change

vchrisb
vchrisb commented May 10, 2022
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
clintonb
clintonb requested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@clintonb clintonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting change from engineer.

@clintonb
Copy link
Contributor

@vchrisb can you update the classifiers in setup.py, too?

@vchrisb
Copy link
Contributor Author

vchrisb commented May 10, 2022 •
edited
Loading

I'll create another pr to increase the test coverage to 95%, once this pr merged.
https://github.com/vchrisb/django-sortedm2m/runs/6368972196?check_suite_focus=true

@clintonb clintonb merged commit 2bfb5f3 into jazzband:master May 10, 2022
@vchrisb vchrisb deleted the django4 branch May 10, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintonb clintonb clintonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchrisb @clintonb