Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

708 - Add Natural Key Support to Tag model. #905

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

Trafire
Copy link
Contributor

@Trafire Trafire commented Jul 14, 2024

#708

Adds the ability to load/dump Tags by by natural keys rather thank PK

@Trafire Trafire marked this pull request as ready for review July 14, 2024 22:09
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.21%. Comparing base (2ecc9c7) to head (0de8a38).
Report is 4 commits behind head on master.

Files Patch % Lines
taggit/models.py 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   91.44%   92.21%   +0.77%     
==========================================
  Files           9        9              
  Lines         736      758      +22     
  Branches      116      137      +21     
==========================================
+ Hits          673      699      +26     
+ Misses         41       37       -4     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taggit/models.py Outdated Show resolved Hide resolved
taggit/models.py Outdated Show resolved Hide resolved
@rtpg rtpg merged commit b2906a9 into jazzband:master Jul 25, 2024
7 checks passed
@tim-schilling
Copy link

@rtpg when you have time, can you apply the djangonauts-reserved label to the following PRs (github allows you to mass apply labels from the list view):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants