Fix bug with merge form action when querystring is present. #927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querystrings are preventing the tags from merging, because
get_full_path()
in the redirect preserves querystrings.Steps to reproduce
slug
so that the path is/admin/taggit/tag/?o=2.1
(with querystring)Result
Because the resulting path is
/admin/taggit/tag/?o=2.1merge-tags/
you stay on the listing page.This also affects paging querystrings.
Fix
Use
request.path
instead ofrequest.get_full_path()
.