pip-compile loses VCS egg name from setup.py

[bo5o]

When using a simple layered dependency workflow (production->development requirements) the egg name specified in setup.py is missing in requirements.txt. This causes duplicate entries of same vcs url in dev-requirements.txt if a vcs dependency itself depends on another vcs dependency.

Environment Versions

OS Type: Ubuntu GNU/Linux v18.04
Python version: 3.7.4
pip version: 19.2.3
pip-tools version: 4.1.0

Steps to replicate

1. Create setup.py with vcs url in install_requires

from setuptools import setup
setup(
    ...,
    install_requires=['mypackage @ <vcs_url>'],
    ...,
)

2. Compile requirements.txt.

Expected result

<vcs_url>#egg=mypackage

Actual result

<vcs_url>

Workaround

Specifying the egg name explicitly in vcs url in setup.py

from setuptools import setup
setup(
    ...,
    install_requires=['mypackage @ <vcs_url>#egg=mypackage'],
    ...,
)

will produce the expected result.

[atugushev]

Hello @cbows,

Thanks for bringing up this!

FTR and truly curious:

• there is a related issue @ delimiter for url is not supported #854 and it looks like the proper support of name@url is going to be released in pip==19.3. See Fix is_url from splitting the scheme incorrectly when using PEP 440's direct references pypa/pip#6203.
• mypackage @ <vcs_url> dependency specification described in PEP 508.
• egg framents specification described in pip install documentation.

[atugushev]

FTR, related discussion about PEP 508 on python packaging forum.

[sambarluc]

I guess the same question I posted in #1111 (comment) is relevant here too.

[atugushev]

Can't reproduce anymore with pip-tools-6.11.0. I believe it was fixed in #1455.

# setup.py
from setuptools import setup
setup(
    name="bar",
    version="0.1",
    install_requires=['six @ git+https://github.com/atugushev/six'],
)

$ pip-compile --resolver=backtracking
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
#    pip-compile --resolver=backtracking
#
six @ git+https://github.com/atugushev/six
    # via bar (setup.py)

So I close this as completed. Feel free to reopen if you think that the issue is not resolved. Thanks!