Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate PEP 440 direct reference whenever possible #1455

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Generate PEP 440 direct reference whenever possible #1455

merged 4 commits into from
Aug 3, 2021

Conversation

FlorentJeannot
Copy link
Contributor

@FlorentJeannot FlorentJeannot commented Jul 17, 2021 •
edited by atugushev
Loading

This PR converts a requirement as a direct reference whenever possible, to mimic pip's behavior.
See these links for more information:

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@FlorentJeannot FlorentJeannot mentioned this pull request Jul 17, 2021
Merged
3 tasks
@atugushev atugushev added the enhancement Improvements to functionality label Aug 2, 2021
@atugushev atugushev added this to the 6.3.0 milestone Aug 2, 2021
atugushev and others added 3 commits August 3, 2021 00:31
atugushev
atugushev approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev added the writer Related to results output writer component label Aug 3, 2021
@atugushev atugushev merged commit 51cae74 into jazzband:master Aug 3, 2021
@atugushev
Copy link
Member

@FlorentJeannot thanks!

@FlorentJeannot
Copy link
Contributor Author

You're welcome!

@mzulqarnain1 mzulqarnain1 mentioned this pull request Sep 27, 2021
Merged
@atugushev atugushev mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
enhancement Improvements to functionality writer Related to results output writer component
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentJeannot @atugushev