Do the basic configuration of the builtin logging module #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jazzband#292 In a normal use case, `pip` would take care of configuring the logging module as intended. But due to our intrusive import of pip internals, that part wasn't properly done.
vphilippon
force-pushed
the
configure-builtin-logging-module
branch
from
68a3325 to
cde47c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
- Coverage 99.33% 99.29% -0.05%
==========================================
Files 34 34
Lines 2397 2399 +2
Branches 306 306
==========================================
+ Hits 2381 2382 +1
Misses 8 8
- Partials 8 9 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
In a normal use case,
pipwould take care of configuring the loggingmodule as intended. But due to our intrusive import of pip internals,
that part wasn't properly done.
I think this is a trivial change that we can skip tests for.
Changelog-friendly one-liner: Fix the
No handlers could be found for logger "pip.*"error by configuring the builtin logging module.Contributor checklist