Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pip-20.0 support #1191

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 29, 2020

Due to pip-tools' policy to support only the last two minor pip versions, it's time to drop the pip-20.0.

  • pin pip >= 20.1 in setup.py
  • remove 20.0 compatible code
  • remove 20.0 from CI
  • update "Versions and compatibility" in README

Changelog-friendly one-liner: Drop pip-20.0 support.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev force-pushed the drop-support-pip-20.0 branch from d3715fd to 0bfc6df Compare July 29, 2020 06:25
@atugushev atugushev force-pushed the drop-support-pip-20.0 branch from 0bfc6df to ab4bc1d Compare July 29, 2020 06:26
@atugushev atugushev added this to the 5.4.0 milestone Jul 29, 2020
@atugushev atugushev requested a review from AndydeCleyre July 29, 2020 11:16
Copy link
Contributor

@AndydeCleyre AndydeCleyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! One question for now, and two for the future.

now:

  • Should we remove BAR_TYPES from _compat/{pip_compat,__init__}.py and import it directly in pypi.py?

future:

  • Do you think it would be worth the trouble to template some of these files, for more automated pip-version updates? Specifically: .appveyor.yml, ci.yml, .travis.yml, setup.cfg, tox.ini
  • Do we have special reasons to stick with setup.{cfg,py} for now, rather than moving to pyproject.toml?

@atugushev
Copy link
Member Author

@AndydeCleyre

  • Should we remove BAR_TYPES from _compat/{pip_compat,__init__}.py and import it directly in pypi.py?

Yeah, thanks for noticing!

  • Do you think it would be worth the trouble to template some of these files, for more automated pip-version updates? Specifically: .appveyor.yml, ci.yml, .travis.yml, setup.cfg, tox.ini

Would be nice to automate this.

  • Do we have special reasons to stick with setup.{cfg,py} for now, rather than moving to pyproject.toml?

I'd prefer to stick to setup.cfg since pip doesn't support install editables with pyproject.toml.

Co-Authored-By: Andy Kluger <andydecleyre@gmail.com>
@atugushev
Copy link
Member Author

Thank you @AndydeCleyre for reviewing this! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants