-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix click
v7 version_option
compatibility
#1410
Conversation
Hey there! I wasn't sure how to set a milestone or what milestone should even be set (possibly 6.1.1, just since that's the milestone which was set on #1400?). Would love some help with that! Also, I wasn't sure whether I should add a new |
you're totally right, good catch! As far as I know, only members of the jazzband organisation can set milestones, I added 6.1.1 for now, agreeing that this makes sense. Regarding the tox env: I honestly don't know whether it's overkill or highly appreciated to test different click versions, maybe others have a strong opinion on this. |
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 34 34
Lines 3042 3042
Branches 327 327
=======================================
Hits 3032 3032
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
This will probably need to be synced with master to unblock the merge button. |
It looks like the ternary was committed backwards in #1400, since the `package_name` option was add in click 8, but is only being passed in click 7. That caused `pip-tools` to error on import when installed alongside click 7.
Thank you for the quick review! 😀 I've gone ahead and rebased the branch on latest |
click
v7 version_option
compatibility
It looks like the ternary was committed backwards in #1400, since the
package_name
option was add in click 8, but is only being passed in click 7. That causedpip-tools
to error on import when installed alongside click 7.Changelog-friendly one-liner: Follow up #1400 to fix click v7 compatibility.
Contributor checklist