Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comma-separated arguments for --extra #1493

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Allow comma-separated arguments for --extra #1493

merged 2 commits into from
Sep 28, 2021

Conversation

AndydeCleyre
Copy link
Contributor

@AndydeCleyre AndydeCleyre commented Sep 28, 2021 •
edited by ssbarnea
Loading

Usually the form is --extra ONE --extra TWO --extra THREE. With this change, --extra ONE,TWO --extra THREE will be parsed to achieve the same result.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Fixes: #1430

@AndydeCleyre AndydeCleyre mentioned this pull request Sep 28, 2021
Closed
@ssbarnea ssbarnea added the bug Something is not working label Sep 28, 2021
@ssbarnea ssbarnea changed the title Parse each comma-separated --extra argument to pip-compile as multiple entries Allow comma-separated arguments for --extra Sep 28, 2021
@atugushev atugushev merged commit 83406cb into jazzband:master Sep 28, 2021
@atugushev
Copy link
Member

Thanks, @AndydeCleyre!

@atugushev atugushev changed the title Allow comma-separated arguments for --extra Allow comma-separated arguments for --extra Sep 28, 2021
@atugushev atugushev added this to the 6.3.1 milestone Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
6.3.1
Development

Successfully merging this pull request may close these issues.

--extra=foo,bar does not work as expected
3 participants
@AndydeCleyre @atugushev @ssbarnea