Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a regression with unsafe packages for --allow-unsafe #1788

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Fix a regression with unsafe packages for --allow-unsafe #1788

merged 1 commit into from
Dec 24, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 24, 2022 •
edited by atugushev
Loading

Closes #1786

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

atugushev
atugushev approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@atugushev atugushev added the bug Something is not working label Dec 24, 2022
@atugushev atugushev added this to the 6.12.2 milestone Dec 24, 2022
@atugushev atugushev changed the title Fix a regression with unsafe packages for --allow-unsafe Fix a regression with unsafe packages for --allow-unsafe Dec 24, 2022
@atugushev atugushev enabled auto-merge (squash) December 24, 2022 22:30
@q0w
Copy link
Contributor Author

q0w commented Dec 24, 2022

@atugushev is it correct? #1786 (comment)

@atugushev atugushev merged commit 23d874e into jazzband:main Dec 24, 2022
@q0w q0w deleted the fix-allow-unsafe branch December 25, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
6.12.2
Development

Successfully merging this pull request may close these issues.

Unsafe requirements are no longer included in the requirements.txt generated by pip-compile
2 participants
@q0w @atugushev