Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to --resolver=backtracking #1897

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 1, 2023

Since 7.0.0 is the next release, it's time to switch the default resolver as promised.
Refs: #1659

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added resolver Related to dependency resolver backwards incompatible Backwards incompatible change labels Jul 1, 2023
@atugushev atugushev changed the title Default to --resolver=backtracking Default to --resolver=backtracking Jul 1, 2023
@atugushev atugushev added this to the 7.0.0 milestone Jul 1, 2023
@webknjaz
Copy link
Member

webknjaz commented Jul 1, 2023

Do we want the next version to be 7? I don't think dropping a Python version needs a major bump since python_requires already serves the role of making the installers omit incompatible versions and it's not an API change at all, SemVer-wise.

Though if we were to flip the default, I'd expect it to be aligned with having the pip version that did this minimum supported. And such a change would indeed require a major version bump.

@atugushev
Copy link
Member Author

I believe we should change the default resolver. It's been a year since pip-tools released a new resolver, and since then we haven't received much feedback, so I guess it's about time.

Even though I don't have the stats, I presume that most users still use the legacy resolver, given the minimal feedback on the backtracking resolver. This will give users sufficient time to adapt to the changes before pip drops the legacy resolver, as well as give us time to fix bugs.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I'm concerned that this isn't covered by tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible Backwards incompatible change resolver Related to dependency resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants