Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignorance of inverted CLI options in config for pip-sync #1989

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Fix ignorance of inverted CLI options in config for pip-sync #1989

merged 6 commits into from
Nov 26, 2023

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Sep 20, 2023 •
edited
Loading

Fixes #1988

I can say I feel quite embarrassed.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@chrysle chrysle added bug Something is not working config Related to pip-tools' configuration labels Sep 20, 2023
@chrysle chrysle force-pushed the fix-inverted-options-ignored branch 3 times, most recently from ad82041 to f8ee407 Compare September 20, 2023 14:42
@chrysle chrysle changed the title Fix ignorance of inverted CLI options in config Fix ignorance of inverted CLI options in config for pip-sync Sep 20, 2023
@chrysle chrysle requested a review from webknjaz September 22, 2023 14:29
atugushev
atugushev reviewed Oct 29, 2023
View reviewed changes
piptools/utils.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Nov 2, 2023
View reviewed changes
piptools/utils.py Outdated Show resolved Hide resolved
@webknjaz webknjaz enabled auto-merge November 2, 2023 16:47
@webknjaz webknjaz disabled auto-merge November 2, 2023 17:09
@webknjaz webknjaz enabled auto-merge November 2, 2023 17:50
@chrysle chrysle force-pushed the fix-inverted-options-ignored branch 2 times, most recently from 14ab4bc to b080617 Compare November 26, 2023 15:01
@chrysle chrysle force-pushed the fix-inverted-options-ignored branch from b080617 to 5e8fbee Compare November 26, 2023 15:03
@webknjaz webknjaz added this pull request to the merge queue Nov 26, 2023
Merged via the queue into jazzband:main with commit fb93ad7 Nov 26, 2023
36 checks passed
@chrysle chrysle deleted the fix-inverted-options-ignored branch November 26, 2023 15:22
@atugushev atugushev added this to the 7.4.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bug Something is not working config Related to pip-tools' configuration
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

Options in pyproject.toml break usage of pip-sync
3 participants
@chrysle @webknjaz @atugushev