-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip-compile includes irrelevant constraints from pip contraints file #471
Merged
davidovich
merged 1 commit into
jazzband:master
from
derek-miller:exclude-pip-constraints
Mar 31, 2017
Merged
pip-compile includes irrelevant constraints from pip contraints file #471
davidovich
merged 1 commit into
jazzband:master
from
derek-miller:exclude-pip-constraints
Mar 31, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone have time to review this? |
Thanks @derek-miller ! |
I have no problem with the fix, it's just that it works very well without the memoization... Would you mind taking #485 for a spin and see if your use case is broken ? |
This was referenced Apr 13, 2017
This was referenced Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip-compile
treats constraints as requirements.https://pip.pypa.io/en/stable/user_guide/#constraints-files
Steps to replicate
constraints.txt
file with the following contents:requirements.in
file with the following contents:pip-compile
Expected result
Actual result