-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --find-links in pip-compile output #793
Add support for --find-links in pip-compile output #793
Conversation
Co-Authored-By: Elvis Stansvik <elvstone@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 98.06% 98.07% +<.01%
==========================================
Files 34 34
Lines 1962 1972 +10
Branches 256 257 +1
==========================================
+ Hits 1924 1934 +10
Misses 26 26
Partials 12 12
Continue to review full report at Codecov.
|
Hello @suutari, Thank you for pointing that out! I agree there should be relative links. I'll port your code here if you don't mind. |
I've found an interesting FIXME comment in
Maybe it's better to fix this case on the |
@atugushev I've been completely swamped and almost forgot about my PR. Thanks for taking care of this! |
We don't need to manually copy over the --find-links option from the input file, pip-compile does that itself since 2019 (v3.7.0). jazzband/pip-tools#793 Differential Revision: https://phabricator.services.mozilla.com/D230910 --HG-- extra : moz-landing-system : lando
This adds support to pip-compile for the -f, --find-links flag in the input requirements.in. Rebased #704 and adjusted tests. Thanks @estan for the contribution!
Changelog-friendly one-liner: Add support for
--find-links
inpip-compile
output.Contributor checklist