Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options --cert and --client-cert to pip-sync #798

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 24, 2019

Closes #713.

Changelog-friendly one-liner: Add options --cert and --client-cert to pip-sync

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the enhancement Improvements to functionality label Apr 24, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #798 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   98.06%   98.07%   +<.01%     
==========================================
  Files          34       34              
  Lines        1965     1971       +6     
  Branches      257      259       +2     
==========================================
+ Hits         1927     1933       +6     
  Misses         26       26              
  Partials       12       12
Impacted Files Coverage Δ
tests/test_cli_sync.py 100% <ø> (ø) ⬆️
piptools/scripts/sync.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da4a25...26493ed. Read the comment docs.

@atugushev atugushev requested review from vphilippon and blueyed April 27, 2019 16:17
@atugushev atugushev added this to the 3.7.0 milestone Apr 28, 2019
@atugushev atugushev merged commit a3ac5ca into jazzband:master Apr 28, 2019
@atugushev
Copy link
Member Author

@blueyed thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--cert option for pip-sync
2 participants