Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for file based --extra-index-url to pip-sync #951

Closed
wants to merge 5 commits into from

Conversation

altendky
Copy link

Any --extra-index-url that are added inside the requirements.txt file are ignored. This change makes sure they are honoured.

This is a catchup for #674

Changelog-friendly one-liner: Added support for --extra-index-urls options inside requirements.txt files

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

willhardy and others added 3 commits August 20, 2018 20:36
@altendky altendky changed the title Altendky extra index urls Add support for file based --extra-index-urls to pip-sync Oct 19, 2019
@altendky altendky changed the title Add support for file based --extra-index-urls to pip-sync [WIP] Add support for file based --extra-index-urls to pip-sync Oct 19, 2019
@altendky altendky changed the title [WIP] Add support for file based --extra-index-urls to pip-sync [WIP] Add support for file based --extra-index-url to pip-sync Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #951 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage    99.1%   99.11%   +0.01%     
==========================================
  Files          35       35              
  Lines        2336     2377      +41     
  Branches      301      307       +6     
==========================================
+ Hits         2315     2356      +41     
  Misses         13       13              
  Partials        8        8
Impacted Files Coverage Δ
piptools/scripts/sync.py 100% <100%> (ø) ⬆️
tests/test_cli_sync.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
tests/utils.py 100% <100%> (ø) ⬆️
tests/conftest.py 98.23% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023d7ca...47c9f01. Read the comment docs.

@atugushev
Copy link
Member

atugushev commented Oct 19, 2019

Hello @altendky,

Thanks for working on this! FTR, It's also implemented in #824 as a comprehensive solution with support the other options, but a little bit stalled.

@atugushev atugushev closed this Oct 19, 2019
@atugushev atugushev reopened this Oct 19, 2019
@atugushev
Copy link
Member

Sorry, accidentally closed PR :(

@altendky
Copy link
Author

Guess I should have been more careful about what PR to update. :[ Probably ought to just close these if #824 does it all I guess.

@atugushev
Copy link
Member

atugushev commented Oct 19, 2019

@altendky

I've rebased #824 and refactored it, could you review/test it?

@atugushev
Copy link
Member

Superseded by #824.

@atugushev atugushev closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants