Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #496 - Allow skipping lines when reading xls/xlsx/csv files #497

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Fixes #496 - Allow skipping lines when reading xls/xlsx/csv files #497

merged 2 commits into from
Sep 4, 2021

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Sep 2, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #497 (ccd5429) into master (eba2f6f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   90.69%   90.78%   +0.08%     
==========================================
  Files          28       28              
  Lines        2623     2647      +24     
==========================================
+ Hits         2379     2403      +24     
  Misses        244      244
Impacted Files Coverage Δ
src/tablib/formats/_csv.py 100.00% <100.00%> (ø)
src/tablib/formats/_xls.py 85.10% <100.00%> (+0.32%) ⬆️
src/tablib/formats/_xlsx.py 97.00% <100.00%> (+0.06%) ⬆️
tests/test_tablib.py 98.60% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba2f6f...ccd5429. Read the comment docs.

hugovk
hugovk approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions, looks good.

docs/formats.rst Outdated Show resolved Hide resolved
src/tablib/formats/_csv.py Outdated Show resolved Hide resolved
src/tablib/formats/_xlsx.py Outdated Show resolved Hide resolved
@claudep @hugovk
Apply suggestions from code review
ccd5429 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@claudep
Copy link
Contributor Author

claudep commented Sep 4, 2021

Thanks for the review!

@claudep claudep merged commit ebd916e into jazzband:master Sep 4, 2021
@claudep claudep deleted the skip_lines branch September 4, 2021 08:48
@hugovk hugovk mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudep @hugovk