doubled sample size passed to csv.Sniffer() in _csv.detect() #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubling the stream read sample in detect() from 1024 to 2048 to make csv.Sniffer().sniff() more reliable.
|
Thanks for the PR! The failing tests are unrelated, we need to merge #501 first. @julianebeli Looks good, please could you edit the PR title to something a little more descriptive? Normally we'd need tests for fixes, but we may be fine skipping them here (but of course check they still pass once #501 is merged). @claudep, what do you think? |
|
Agreed, a test isn't absolutely required in this case. |
julianebeli
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doubling the stream read sample in detect() from 1024 to 2048 to make csv.Sniffer().sniff() more reliable.
Closes #502