fix #524 check for type list and improve error msg #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 90.95% 90.97% +0.02%
==========================================
Files 28 28
Lines 2652 2660 +8
==========================================
+ Hits 2412 2420 +8
Misses 240 240
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
claudep
reviewed
Jan 19, 2023
tests/test_tablib.py
Outdated
| def test_yaml_load(self): | ||
| """ test issue 524: invalid format """ | ||
| yaml_source = Path(__file__).parent / 'files' / 'issue_524.yaml' | ||
| with open(str(yaml_source), mode='rb') as fh: |
There was a problem hiding this comment.
I think you should be able to write with yaml_source.open(mode='rb') as fh:
claudep
approved these changes
Jan 20, 2023
|
Noticed that coverage job failed on master. I will fix it with a new PR. |
|
Frankly, coverage reports are generally so broken I don't even consider them. |
|
Just in case created this PR https://github.com/jazzband/tablib/pull/535/files Found a small bug when using empty files. Not sure if it is better to raise an exception or return empty list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test to reproduce the issue #524 and improve error message