Add edit_handler to AbstractMainMenu, AbstractFlatMenu #464

[yarickprih]

Resolves #464

Extend AbstractMainMenu and AbstractFlatMenu with edit_handler attribute in order to support wagtail 5.2 requirements for non-Page models content tabs.

[yarickprih]

@ababic, the code coverage decreased 1% but i'm not exactly sure how to test edit_handler attributes. I've updated a single place in the tests where i though it would be appropriate to include edit_handler.
I'd be thankful If you could point or advice on that.

[ababic]

Hi @yarickprih. These changes aren't actually needed, because the custom views used by wagtailmenus generate their own edit handler from the content_panels and settings_panels attributes on the model.

Adding these edit_handler attributes to the models actually means that, in order to add their own panels to either tab, developers need to completely override edit_handler instead of just adding items to content_panels and settings_panels (like they can currently).

[yarickprih]

Hi @yarickprih. These changes aren't actually needed, because the custom views used by wagtailmenus generate their own edit handler from the content_panels and settings_panels attributes on the model.

Adding these edit_handler attributes to the models actually means that, in order to add their own panels to either tab, developers need to completely override edit_handler instead of just adding items to content_panels and settings_panels (like they can currently).

Yeah, didn't notice that part in the views. I was mainly aiming to get rid of wagtail warnings.
If this PR is not really required i'll close it

[ababic]

Yeah, didn't notice that part in the views. I was mainly aiming to get rid of wagtail warnings.
If this PR is not really required i'll close it

Sorry @yarickprih, I was a little blunt in my previous reply. I haven't been involved in this project for a long while, so the notifications caused a bit of panic! It was awesome of you to hop onto this. But alas, I do think we need to approach this a little differently.

[yarickprih]

Yeah, didn't notice that part in the views. I was mainly aiming to get rid of wagtail warnings.
If this PR is not really required i'll close it

Sorry @yarickprih, I was a little blunt in my previous reply. I haven't been involved in this project for a long while, so the notifications caused a bit of panic! It was awesome of you to hop onto this. But alas, I do think we need to approach this a little differently.

Sorry for bothering @ababic, i have just a single question
who can i contact with regarding reviews/questions on this project (if you know ofc)?
i have 1 more small PR with translations that i'd like to be reviewed