asciidoc related enhancements #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids having problems in feed and archive with dates. Allows us to define another templates for each page type.
because WE are generating our sites. 2. asciidoc set base dir to be jbake root, now it is easy to include::content/* in our asciidoc sites.
insted of February.
|
Thanks for the contribution! I may look at separating out the changes, so the Asciidoctor safe mode change is included in v2.2.1 and the change to the convention that everything is a post by default to a later release, might be best to re-think the situation completely. |
before the latest overwrote the previous. The default.property asciidoctor.options=source-highlighter=prettify if still overwritten when custom property is defined.
where KKK is the asciidoc key.
Because we don't know the type we guess them by their content. not perfect but ok for boolean,int and string.
ghost
assigned 
|
Thanks again for the contribution. Hope you don't mind but I've hard coded the Asciidoctor safe mode to unsafe, because I couldn't think of a use case when you'd want to change this value, but if you have a scenario please let me know. I'll raise a separate issue to change the convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made some changes to your code. You might find them as useful as I do.
Cheers,
Vadim