lift::client destructor infinite loop with libuv >= 1.48 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* libuv >= 1.48 at least has changed how uv loops get shutdown * The loop seems to need to release its own resources * Introduced a new async channel for shutdown for the loop to cleanup its own uv_handle_t objects. Closes #149
jbaldwin
force-pushed
the
issue-149/lift-client-destructor-infinite-loop
branch
5 times, most recently
from
e4e0eaf
to
9322e95
Compare
jbaldwin
force-pushed
the
issue-149/lift-client-destructor-infinite-loop
branch
from
9322e95
to
229adb4
Compare
jbaldwin
force-pushed
the
issue-149/lift-client-destructor-infinite-loop
branch
from
7fe0741
to
8784ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149