Skip to content

Commit

Permalink
fix($rootScope): fix potential memory leak when removing scope listeners
Browse files Browse the repository at this point in the history
When removing listeners they are removed from the array but the array size is not changed
until the event is fired again. If the event is never fired but listeners are added/removed then
the array will continue growing.

By changing the listener removal to `delete` the array entry instead of setting it to `null`
browsers can potentially deallocate the memory for the entry.

Fixes angular#16135
  • Loading branch information
jbedard committed Sep 10, 2017
1 parent d1e971b commit 396566f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/ng/rootScope.js
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,10 @@ function $RootScopeProvider() {
return function() {
var indexOfListener = namedListeners.indexOf(listener);
if (indexOfListener !== -1) {
namedListeners[indexOfListener] = null;
// Use delete in the hope of the browser deallocating the memory for the array entry,
// while not shifting the array indexes of other listeners.
// See issue https://github.com/angular/angular.js/issues/16135
delete namedListeners[indexOfListener];
decrementListenerCount(self, 1, name);
}
};
Expand Down

0 comments on commit 396566f

Please sign in to comment.