-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up preprocessing module #124
Closed
mk2510
wants to merge
17
commits into
jbesomi:master
from
SummerOfCode-NoHate:speed_up_preprocessing
Closed
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3ab14fd
Speed up default clean function
e0f02c5
Regex pattern to constancs
mk2510 2ea3caf
changed clean function docstring
mk2510 697a229
removed default pipeline for cleaning
mk2510 4bb9860
added unittest for the clean function
mk2510 57c37c1
format file
mk2510 db4934e
added unit test for clean function
mk2510 5887485
updated naming schema
mk2510 addc23b
improved comment on helper function _get_pattern_for_tokenasiton()
mk2510 84652ee
fixed spelling mistake
mk2510 3e7056b
Merge remote-tracking branch 'upstream/master' into speed_up_preproce…
mk2510 16b775f
fixed some merge conflicts
mk2510 0b41020
Merge remote-tracking branch 'upstream/master' into speed_up_preproce…
mk2510 efdc3c9
changed comment
mk2510 e627126
replaced sub with replace
mk2510 f4a91fa
changed back to re.sub
mk2510 d4d394b
updated format
mk2510 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we really need so many tests for this part ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those test will help us to cover all different sections of the pipeline individually, so if something gets changed, we know, which part is broken