Fix locally scoped constant array (#644)

* add failing test for LocallyScopedConstantArray

* add LocallyScopedConstantArray target assembly

* ElementType.Array should be treated the same as object in ReadLocalConstant

* assert constant is null

* Style fixes

Co-authored-by: Jb Evain <jb@evain.net>

Mono.Cecil/AssemblyReader.cs

@@ -3017,7 +3017,7 @@ ConstantDebugInformation ReadLocalConstant (uint rid)
 				value = new decimal (signature.ReadInt32 (), signature.ReadInt32 (), signature.ReadInt32 (), (b & 0x80) != 0, (byte) (b & 0x7f));
 			} else if (type.IsTypeOf ("System", "DateTime")) {
 				value = new DateTime (signature.ReadInt64());
-			} else if (type.etype == ElementType.Object || type.etype == ElementType.None || type.etype == ElementType.Class) {
+			} else if (type.etype == ElementType.Object || type.etype == ElementType.None || type.etype == ElementType.Class || type.etype == ElementType.Array) {
 				value = null;
 			} else
 				value = signature.ReadConstantSignature (type.etype);

Test/Mono.Cecil.Tests/ImageReadTests.cs

@@ -207,6 +207,20 @@ public void Net471TargetingAssembly ()
 			});
 		}
 
+		[Test]
+		public void LocallyScopedConstantArray ()
+		{
+			TestModule ("LocallyScopedConstantArray.dll", module => {
+				Assert.IsTrue (module.HasDebugHeader);
+				var method = module.Types
+					.Single (x => x.Name == "TestClass")
+					.Methods
+					.Single (x => x.Name == "TestMethod");
+				var debugInformation = method.DebugInformation;
+				Assert.IsNull (debugInformation.Scope.Constants.Single ().Value);
+			}, symbolReaderProvider: typeof (PortablePdbReaderProvider), symbolWriterProvider: typeof (PortablePdbWriterProvider));
+		}
+
 		[Test]
 		public void ExternalPdbDeterministicAssembly ()
 		{