-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence points can no longer be cleared when using deferred reading mode #694
Comments
ltrzesniewski
added a commit
to ltrzesniewski/InlineIL.Fody
that referenced
this issue
Oct 2, 2020
@ltrzesniewski good catch. Could you submit a failing test? Thank you! |
ltrzesniewski
added a commit
to ltrzesniewski/cecil
that referenced
this issue
Oct 2, 2020
If you need to revert it's okay for me I did a workaround on wasm debugger side. |
Cool, let's do that then. |
jbevain
added a commit
that referenced
this issue
Oct 13, 2020
Fixed in master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a regression introduced by #686. When using the deferred reading mode, if you clear the sequence points of a method, those will be read again from the source file on writing.
Here's a repro:
This prints the following on v0.11.3:
It prints the expected result on v0.11.2, or if you set
ReadingMode = ReadingMode.Immediate
inReaderParameters
:I'm not entirely sure what the proper fix would be here. Maybe an additional flag is needed to tell if debug information has been read, so the status does not depend on sequence points.
/cc @thaystg FYI
The text was updated successfully, but these errors were encountered: