Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid ComputeHash from ByteByffer array computation #622

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Oct 18, 2019

Addresses #770, where MVID computation in deterministic mode can be incorrect

@jeromelaban
Copy link
Contributor Author

jeromelaban commented Oct 18, 2019

@jbevain Is it expected that lots of tests are failing with this message ?

The assembly is built by a runtime newer than the currently loaded runtime, and cannot be loaded.

@@ -146,7 +146,7 @@ static void CopyStreamChunk (Stream stream, Stream dest_stream, byte [] buffer,

using (var crypto_stream = new CryptoStream (Stream.Null, sha1, CryptoStreamMode.Write)) {
for (int i = 0; i < buffers.Length; i++) {
crypto_stream.Write (buffers [0].buffer, 0, buffers [0].length);
crypto_stream.Write (buffers [i].buffer, 0, buffers [i].length);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch!

@jbevain
Copy link
Owner

jbevain commented Oct 18, 2019

@jeromelaban thanks for the PR and for finding this.

Obviously the errors are unexpected. No idea what changed since it's been working fine, I suspect a change in the GitHub actions VM environment. I'll look into that, in the meantime, this should be good to go.

@jbevain jbevain merged commit 99a6d0e into jbevain:master Oct 18, 2019
@jeromelaban jeromelaban deleted the dev/jela/mvid-fix branch October 18, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants